Fix a few issues in get_object_info_execute in AuthorityAggregator #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
We added a dedicated |
lxfind
force-pushed
the
cleanup-get_object_info
branch
2 times, most recently
from
c27eae1 to
40d9c96
Compare
huitseeker
previously requested changes
Feb 18, 2022
lxfind
force-pushed
the
cleanup-get_object_info
branch
2 times, most recently
from
59e8b6a to
9e698e1
Compare
|
Added TODOs |
gdanezis
approved these changes
Feb 18, 2022
|
Also, lets make a note: the code here relies on collecting lots of effects to check correct execution. It would be far simpler to provide object inputs and re-executing on the client instead. |
|
How can it be simpler? We need to have the authorities process the certificate anyway, right? |
lxfind
force-pushed
the
cleanup-get_object_info
branch
from
9e698e1 to
ff6f9f3
Compare
huitseeker
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 issues along with some cleanups in the function:
mutatedandcreatedbut that doesn't include the gas object. Using the proper API for it. On a side note, maybe we should havemutatedto include the gas object. Otherwise it's confusing. In anyway using a simpler API call make this easier.